Refactor pkg test helper functions #1678

kevindiu · 2022-05-25T06:20:02Z

Description:

This PR refactor pkg/agent/handler test implementation.
The changes and the discussion is as the following link:
#1675

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.18.2
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 1.14.5

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2022-05-25T06:20:17Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

codecov · 2022-05-25T06:27:31Z

Codecov Report

Merging #1678 (c477b85) into master (815b44a) will increase coverage by 0.21%.
The diff coverage is 89.77%.

@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
+ Coverage   31.16%   31.37%   +0.21%     
==========================================
  Files         372      374       +2     
  Lines       32503    32591      +88     
==========================================
+ Hits        10130    10226      +96     
+ Misses      21993    21984       -9     
- Partials      380      381       +1

Impacted Files	Coverage Δ
internal/test/data/vector/gen.go	`93.40% <77.77%> (-6.60%)`	⬇️
internal/test/data/request/insert.go	`92.10% <92.10%> (ø)`
internal/conv/conv.go	`76.66% <100.00%> (+11.66%)`	⬆️
internal/test/data/request/object.go	`100.00% <100.00%> (ø)`
pkg/agent/core/ngt/service/option.go	`89.57% <0.00%> (-1.85%)`	⬇️
internal/worker/queue.go	`98.73% <0.00%> (-1.27%)`	⬇️
internal/worker/worker.go	`84.37% <0.00%> (+0.78%)`	⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go	`78.68% <0.00%> (+5.46%)`	⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go	`76.66% <0.00%> (+5.55%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815b44a...c477b85. Read the comment docs.

internal/test/data/charset/convert.go

internal/test/data/request/insert.go

internal/test/data/request/object.go

pkg/agent/core/ngt/handler/grpc/handler_test.go

internal/test/data/vector/gen.go

pkg/agent/core/ngt/handler/grpc/handler_test.go

kevindiu · 2022-06-01T01:38:42Z

/format

vdaas-ci · 2022-06-01T01:39:53Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

pkg/agent/core/ngt/handler/grpc/handler_test.go

internal/test/data/request/insert.go

internal/test/data/request/object.go

internal/test/data/request/insert.go

internal/test/data/request/object.go

internal/test/data/vector/gen.go

internal/test/data/request/object.go

internal/conv/conv.go

internal/test/data/request/insert_test.go

Signed-off-by: kevindiu <kevindiujp@gmail.com>

internal/test/data/request/object_test.go

Signed-off-by: kevindiu <kevindiujp@gmail.com>

internal/test/data/vector/gen_test.go

internal/conv/conv.go

Signed-off-by: kevindiu <kevindiujp@gmail.com>

internal/conv/conv.go

internal/conv/conv_test.go

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

internal/conv/conv_test.go

internal/test/data/vector/gen_test.go

internal/test/data/request/object_test.go

internal/test/data/request/insert_test.go

Signed-off-by: kevindiu <kevindiujp@gmail.com>

kevindiu force-pushed the refactor/test/separate-pkg-test-helper branch from adb6d0c to 8d3bbab Compare May 25, 2022 06:20

github-actions bot added area/agent/core area/internal team/set SET team size/XL type/refactoring priority/low labels May 25, 2022

kpango marked this pull request as draft May 25, 2022 07:05

kpango changed the title ~~Refactor pkg test helper functions~~ [WIP] Refactor pkg test helper functions May 25, 2022

github-actions bot reviewed May 25, 2022

View reviewed changes

internal/test/data/charset/convert.go Outdated Show resolved Hide resolved

internal/test/data/request/insert.go Show resolved Hide resolved

internal/test/data/request/object.go Outdated Show resolved Hide resolved

github-actions bot reviewed May 26, 2022

View reviewed changes

internal/test/data/request/object.go Show resolved Hide resolved

github-actions bot reviewed May 30, 2022

View reviewed changes

pkg/agent/core/ngt/handler/grpc/handler_test.go Outdated Show resolved Hide resolved

kmrmt requested changes May 31, 2022

View reviewed changes

github-actions bot added size/XXL and removed size/XL labels May 31, 2022

github-actions bot reviewed May 31, 2022

View reviewed changes

pkg/agent/core/ngt/handler/grpc/handler_test.go Outdated Show resolved Hide resolved

pkg/agent/core/ngt/handler/grpc/handler_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed May 31, 2022

View reviewed changes

pkg/agent/core/ngt/handler/grpc/handler_test.go Show resolved Hide resolved

kevindiu marked this pull request as ready for review June 1, 2022 01:56

kevindiu changed the title ~~[WIP] Refactor pkg test helper functions~~ Refactor pkg test helper functions Jun 1, 2022

kevindiu requested review from kmrmt and vankichi June 1, 2022 01:56

github-actions bot reviewed Jun 1, 2022

View reviewed changes

pkg/agent/core/ngt/handler/grpc/handler_test.go Outdated Show resolved Hide resolved

internal/test/data/request/insert.go Show resolved Hide resolved

internal/test/data/request/object.go Show resolved Hide resolved

internal/test/data/request/object.go Outdated Show resolved Hide resolved

github-actions bot reviewed Jun 1, 2022

View reviewed changes

internal/test/data/request/insert.go Show resolved Hide resolved

internal/test/data/request/object.go Show resolved Hide resolved

vankichi reviewed Jun 1, 2022

View reviewed changes

internal/test/data/vector/gen.go Outdated Show resolved Hide resolved

internal/test/data/request/object.go Outdated Show resolved Hide resolved

internal/conv/conv.go Outdated Show resolved Hide resolved

kevindiu requested a review from vankichi June 1, 2022 07:11

kevindiu commented Jun 1, 2022

View reviewed changes

internal/test/data/request/insert_test.go Show resolved Hide resolved

kevindiu added 3 commits June 1, 2022 18:22

implement conv test

928b4c8

Signed-off-by: kevindiu <kevindiujp@gmail.com>

fix golangci warning

9eb32fc

Signed-off-by: kevindiu <kevindiujp@gmail.com>

fix comment

c203493

Signed-off-by: kevindiu <kevindiujp@gmail.com>

kevindiu force-pushed the refactor/test/separate-pkg-test-helper branch from b70cf9d to c203493 Compare June 1, 2022 09:22

github-actions bot reviewed Jun 1, 2022

View reviewed changes

internal/test/data/request/object_test.go Outdated Show resolved Hide resolved

kevindiu added 2 commits June 2, 2022 10:12

fix golangci warning

c85b54c

Signed-off-by: kevindiu <kevindiujp@gmail.com>

split encode()

5ad9c5a

Signed-off-by: kevindiu <kevindiujp@gmail.com>

vankichi reviewed Jun 2, 2022

View reviewed changes

internal/test/data/vector/gen_test.go Outdated Show resolved Hide resolved

vankichi reviewed Jun 2, 2022

View reviewed changes

internal/conv/conv.go Outdated Show resolved Hide resolved

kevindiu added 2 commits June 2, 2022 10:24

implement boundary value test for vector/gen

b6591a4

Signed-off-by: kevindiu <kevindiujp@gmail.com>

use io instead of ioutil package

f60334a

Signed-off-by: kevindiu <kevindiujp@gmail.com>

kevindiu requested a review from vankichi June 2, 2022 01:26

vankichi reviewed Jun 2, 2022

View reviewed changes

internal/conv/conv.go Show resolved Hide resolved

kevindiu requested a review from vankichi June 2, 2022 01:51

github-actions bot reviewed Jun 2, 2022

View reviewed changes

internal/conv/conv_test.go Outdated Show resolved Hide resolved

Update internal/conv/conv_test.go

dd4d4f7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Jun 2, 2022

View reviewed changes

internal/conv/conv_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Jun 2, 2022

View reviewed changes

internal/conv/conv_test.go Outdated Show resolved Hide resolved

vankichi reviewed Jun 2, 2022

View reviewed changes

internal/test/data/vector/gen_test.go Outdated Show resolved Hide resolved

vankichi reviewed Jun 2, 2022

View reviewed changes

internal/test/data/request/object_test.go Show resolved Hide resolved

vankichi reviewed Jun 2, 2022

View reviewed changes

internal/test/data/request/insert_test.go Outdated Show resolved Hide resolved

kevindiu added 3 commits June 2, 2022 14:31

add boundary tests

be8dd0b

Signed-off-by: kevindiu <kevindiujp@gmail.com>

fix test error

082ac19

Signed-off-by: kevindiu <kevindiujp@gmail.com>

add more boundary tests

c477b85

Signed-off-by: kevindiu <kevindiujp@gmail.com>

kevindiu requested a review from vankichi June 2, 2022 07:09

kmrmt approved these changes Jun 2, 2022

View reviewed changes

vankichi approved these changes Jun 2, 2022

View reviewed changes

vankichi merged commit 626c706 into master Jun 2, 2022

vankichi deleted the refactor/test/separate-pkg-test-helper branch June 2, 2022 08:27

hlts2 mentioned this pull request Jun 8, 2022

[patch] release v1.5.4 #1698

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor pkg test helper functions #1678

Refactor pkg test helper functions #1678

kevindiu commented May 25, 2022

vdaas-ci commented May 25, 2022

codecov bot commented May 25, 2022 •

edited

Loading

kevindiu commented Jun 1, 2022

vdaas-ci commented Jun 1, 2022

Refactor pkg test helper functions #1678

Refactor pkg test helper functions #1678

Conversation

kevindiu commented May 25, 2022

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented May 25, 2022

codecov bot commented May 25, 2022 • edited Loading

Codecov Report

kevindiu commented Jun 1, 2022

vdaas-ci commented Jun 1, 2022

codecov bot commented May 25, 2022 •

edited

Loading